Skip to content

Conversation

@ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented May 3, 2025

Description

Now that tmp files are retained from homebrew build and test steps, the gcno files should remain intact.

Depends on gcovr/gcovr#1047

TODO:

  • coverage on Ubuntu runners (required same version of gcov and gcc)
  • coverage on macOS runners (not sure why this isn't working... will worry about it later)

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

@codecov
Copy link

codecov bot commented May 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 15.27%. Comparing base (a0a9713) to head (52629c6).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3842      +/-   ##
==========================================
+ Coverage   14.26%   15.27%   +1.01%     
==========================================
  Files          89       91       +2     
  Lines       18906    18971      +65     
  Branches     8662     8702      +40     
==========================================
+ Hits         2696     2898     +202     
- Misses      14439    15013     +574     
+ Partials     1771     1060     -711     
Flag Coverage Δ
FreeBSD-14.3-aarch64 ?
FreeBSD-14.3-amd64 13.58% <ø> (-0.01%) ⬇️
Homebrew-ubuntu-latest 13.77% <ø> (?)
Linux-AppImage 11.58% <ø> (ø)
Windows-AMD64 13.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 45 files with indirect coverage changes

@ReenigneArcher ReenigneArcher force-pushed the ci/homebrew/enable-test-coverage branch 11 times, most recently from 09350b4 to bccfda2 Compare May 4, 2025 15:23
@codecov
Copy link

codecov bot commented May 4, 2025

Bundle Report

Bundle size has no change ✅

@ReenigneArcher ReenigneArcher force-pushed the ci/homebrew/enable-test-coverage branch 13 times, most recently from 52eb7ae to 6cf5e8a Compare May 8, 2025 01:04
@LizardByte-bot
Copy link
Member

It looks like this PR has been idle for 90 days. If it's still something you're working on or would like to pursue, please leave a comment or update your branch. Otherwise, we'll be closing this PR in 10 days to reduce our backlog. Thanks!

@ReenigneArcher ReenigneArcher force-pushed the ci/homebrew/enable-test-coverage branch from 6cf5e8a to 5772a12 Compare September 1, 2025 19:09
@ReenigneArcher ReenigneArcher force-pushed the ci/homebrew/enable-test-coverage branch from ac5a86a to c88af19 Compare September 2, 2025 13:09
@ReenigneArcher ReenigneArcher added the help wanted Extra attention is needed label Sep 2, 2025
@ReenigneArcher ReenigneArcher force-pushed the ci/homebrew/enable-test-coverage branch 9 times, most recently from ab5edc0 to 3f3e2da Compare September 7, 2025 01:05
@ReenigneArcher ReenigneArcher force-pushed the ci/homebrew/enable-test-coverage branch from 3f3e2da to 0dd02ce Compare October 6, 2025 22:07
@ReenigneArcher ReenigneArcher force-pushed the ci/homebrew/enable-test-coverage branch from 0dd02ce to 30b9f34 Compare November 26, 2025 13:15
@LizardByte LizardByte deleted a comment from sonarqubecloud bot Nov 26, 2025
@ReenigneArcher ReenigneArcher force-pushed the ci/homebrew/enable-test-coverage branch 3 times, most recently from 048eb2f to 878d8f0 Compare November 26, 2025 13:46
@LizardByte LizardByte deleted a comment from sonarqubecloud bot Nov 26, 2025
@ReenigneArcher ReenigneArcher removed the help wanted Extra attention is needed label Nov 26, 2025
@ReenigneArcher ReenigneArcher force-pushed the ci/homebrew/enable-test-coverage branch 2 times, most recently from d427f0d to e7524b6 Compare November 26, 2025 15:37
GCC dependency and related environment setup are now only applied on Linux, aligning with platform-specific requirements. The gcovr coverage generation and assertion are also restricted to Linux.
Adds a 'coverage' flag to each job in the CI matrix and updates the upload step to only run when coverage is enabled for that job. This allows more granular control over which environments generate and upload coverage reports.
@ReenigneArcher ReenigneArcher force-pushed the ci/homebrew/enable-test-coverage branch from 9bada82 to 52629c6 Compare December 1, 2025 01:17
@ReenigneArcher ReenigneArcher marked this pull request as ready for review December 1, 2025 01:18
@ReenigneArcher ReenigneArcher changed the title ci(homebrew): enable test coverage ci(homebrew): enable test coverage on Linux Dec 1, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 1, 2025

Please retry analysis of this Pull-Request directly on SonarQube Cloud

@ReenigneArcher ReenigneArcher merged commit 4d2391c into master Dec 1, 2025
51 of 52 checks passed
@ReenigneArcher ReenigneArcher deleted the ci/homebrew/enable-test-coverage branch December 1, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants